TYP: core.sorting #41285
Merged
TYP: core.sorting #41285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just tried zip(*(maybe_lift(label, shape_) for label, shape_ in zip(labels, shape)))and it seems to work: diff --git a/pandas/core/sorting.py b/pandas/core/sorting.py
index ee62254052..dc4c21a3e4 100644
--- a/pandas/core/sorting.py
+++ b/pandas/core/sorting.py
@@ -147,9 +147,7 @@ def get_group_index(labels, shape: Shape, sort: bool, xnull: bool):
if not xnull:
# error: Incompatible types in assignment (expression has type
# "List[_T]", variable has type "List[int]")
- labels, lshape = map( # type: ignore[assignment]
- list, zip(*map(maybe_lift, labels, lshape))
- )
+ labels, shape = zip(*(maybe_lift(label, shape_) for label, shape_ in zip(labels, shape)))
labels = list(labels)$ mypy pandas
Success: no issues found in 1283 source files
|
|
@MarcoGorelli is there a convenient way to get rid of the "*"? this feels like the kind of thing where the answer is hitting me in the face... |
|
Could define |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
both mypy and i have a hard time with
labels, lshape = map(list, zip(*map(maybe_lift, labels, lshape)))